FIX: Respect default category sort order when navigating within app #23270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When navigating around, we make ajax requests with a parameter like `?filter=latest`. This results in the TopicQuery being set up with `filter: "latest"` as a string. The logic introduced in fd9a5bc checks for equality with `:latest` and `:unseen` symbols, which didn't work correctly in this situation This commit makes the logic detect both strings and symbols, and adds a spec for the behaviour.
pmusaraj
approved these changes
Aug 25, 2023
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/category-links-should-honor-category-order-settings/274333/5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating around, we make ajax requests with a parameter like
?filter=latest. This results in the TopicQuery being set up withfilter: "latest"as a string. The logic introduced in fd9a5bc checks for equality with:latestand:unseensymbols, which didn't work correctly in this situationThis commit makes the logic detect both strings and symbols, and adds a spec for the behaviour.